chore: bump trigger #240
chore: bump trigger #240
Conversation
|
""" Walkthrough这次更新主要涉及对项目配置和依赖管理的调整，以及部分文件中导入路径的更新。具体来说，新增了对 Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
docs/examples/arrow.jsxOops! Something went wrong! :( ESLint: 7.32.0 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. docs/examples/context-menu.jsxOops! Something went wrong! :( ESLint: 7.32.0 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. docs/examples/dropdown-menu-width.jsxOops! Something went wrong! :( ESLint: 7.32.0 ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct. The config "prettier" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (7)
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
package.json (2)
36-36: 更新 prepublishOnly 脚本当前把
prepublishOnly脚本改为"npm run compile && rc-np"，从而替换了原先使用的np工具。建议确认新工具rc-np的配置和行为是否完全满足发布时的需求。
53-54: 调整开发依赖项在
devDependencies中新增了"@rc-component/np": "^1.0.3"和"@rc-component/resize-observer": "^1.0.0"，并移除了旧的np依赖。请仔细检查构建和测试脚本，确保所有相关命令和配置已更新为使用新的依赖项。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.gitignore(1 hunks)package.json(3 hunks)src/Dropdown.tsx(1 hunks)src/Overlay.tsx(1 hunks)src/hooks/useAccessibility.ts(2 hunks)tests/basic.test.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- .gitignore
- src/Overlay.tsx
- src/Dropdown.tsx
- src/hooks/useAccessibility.ts
- tests/basic.test.tsx
🔇 Additional comments (2)
package.json (2)
2-2: 包名称更新为 Scoped Package已将包名称从旧的
"rc-dropdown"修改为"@rc-component/dropdown"，符合 scoped package 命名规范，有助于依赖管理和组织结构清晰。
47-49: 更新依赖项版本及新增依赖更新了
"@rc-component/trigger"从^2.0.0升级到^3.0.0，并新增了依赖"@rc-component/util": "^1.2.1"以及"classnames": "^2.2.6"。请确保项目中所有引入这些包的地方均已同步更新，同时确认已移除的依赖（例如"@babel/runtime"、"rc-util"和rc-resize-observer）不会在代码中被继续使用。
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
docs/examples/arrow.jsx(1 hunks)docs/examples/context-menu.jsx(2 hunks)docs/examples/dropdown-menu-width.jsx(2 hunks)docs/examples/multiple.jsx(3 hunks)docs/examples/overlay-callback.jsx(3 hunks)docs/examples/simple.jsx(3 hunks)
✅ Files skipped from review due to trivial changes (5)
- docs/examples/context-menu.jsx
- docs/examples/overlay-callback.jsx
- docs/examples/multiple.jsx
- docs/examples/simple.jsx
- docs/examples/dropdown-menu-width.jsx
🔇 Additional comments (2)
docs/examples/arrow.jsx (2)
2-2: 导入顺序调整合理。Menu 组件的导入顺序调整更加清晰，有助于代码的可读性。
4-4: 资源文件路径引用正确。使用相对路径引用样式文件是合适的做法。
| @@ -1,7 +1,7 @@ | |||
| import Menu, { Item as MenuItem, Divider } from 'rc-menu'; | |||
| import '../../assets/index.less'; | |||
| import Dropdown from '@rc-component/dropdown'; | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
请验证新的依赖包版本。
导入路径从 'rc-dropdown' 更改为 '@rc-component/dropdown'，需要确保新包的兼容性和稳定性。
🏁 Script executed:
#!/bin/bash
# 检查新包的版本信息和依赖关系
npm info @rc-component/dropdown
# 检查是否有未解决的问题
gh api graphql -f query='
{
repository(owner: "react-component", name: "dropdown") {
issues(states: OPEN, first: 5) {
nodes {
title
url
labels(first: 5) {
nodes {
name
}
}
}
}
}
}'Length of output: 1457
依赖包校验失败，请确认包名称和发布状态
经过使用 npm info @rc-component/dropdown 的检查，发现该包未在 npm 注册表中找到（返回 E404 错误），这表明包名称可能存在问题或尚未发布。同时，通过 GitHub 查询看到仓库中的相关 open issues，但这并不能证明该包已正确发布。请确认以下几点：
- 确认依赖包名称是否正确，是否应该继续使用
'@rc-component/dropdown'或恢复为旧的'rc-dropdown'。 - 如果包名称没有问题，请检查 npm 发布流程，确保新版包已经发布到注册表中。
- 若需要使用 GitHub 上的资源，请调整导入路径和相关依赖管理配置。
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
===========================================
- Coverage 100.00% 99.09% -0.91%
===========================================
Files 5 5
Lines 107 110 +3
Branches 31 34 +3
===========================================
+ Hits 107 109 +2
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
2 participants
Summary by CodeRabbit